runtime/vm/flow_graph_builder.cc - Issue 70183010: Fixes a couple problems with GC of unoptimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 70183010: Fixes a couple problems with GC of unoptimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

===================================================================

--- runtime/vm/flow_graph_builder.cc (revision 30598)

+++ runtime/vm/flow_graph_builder.cc (working copy)

@@ -3994,7 +3994,9 @@

new CheckStackOverflowInstr(function.token_pos(), 0);

// If we are inlining don't actually attach the stack check. We must still

// create the stack check in order to allocate a deopt id.

- if (!IsInlining()) for_effect.AddInstruction(check);

+ if (!IsInlining()) {

+ for_effect.AddInstruction(check);

+ }

}

parsed_function()->node_sequence()->Visit(&for_effect);

AppendFragment(normal_entry, for_effect);

« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »