runtime/vm/compiler.cc - Issue 70183010: Fixes a couple problems with GC of unoptimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 70183010: Fixes a couple problems with GC of unoptimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 30598)

+++ runtime/vm/compiler.cc (working copy)

@@ -734,8 +734,10 @@

LongJump* base = isolate->long_jump_base();

LongJump jump;

isolate->set_long_jump_base(&jump);

+ // Make sure unoptimized code is not collected while we are compiling.

+ const Code& unoptimized_code = Code::ZoneHandle(function.unoptimized_code());

// Skips parsing if we need to only install unoptimized code.

- if (!optimized && !Code::Handle(function.unoptimized_code()).IsNull()) {

+ if (!optimized && !unoptimized_code.IsNull()) {

InstallUnoptimizedCode(function);

isolate->set_long_jump_base(base);

return Error::null();

« no previous file with comments | « runtime/vm/code_patcher.h ('k') | runtime/vm/deopt_instructions.h » ('j') | no next file with comments »