Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Side by Side Diff: runtime/vm/stack_frame.cc

Issue 70183010: Fixes a couple problems with GC of unoptimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/visitor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/stack_frame.h" 5 #include "vm/stack_frame.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/deopt_instructions.h" 8 #include "vm/deopt_instructions.h"
9 #include "vm/isolate.h" 9 #include "vm/isolate.h"
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 RawObject** last = reinterpret_cast<RawObject**>( 79 RawObject** last = reinterpret_cast<RawObject**>(
80 fp() + (kFirstLocalSlotFromFp * kWordSize)); 80 fp() + (kFirstLocalSlotFromFp * kWordSize));
81 81
82 // A stack map is present in the code object, use the stack map to 82 // A stack map is present in the code object, use the stack map to
83 // visit frame slots which are marked as having objects. 83 // visit frame slots which are marked as having objects.
84 // 84 //
85 // The layout of the frame is (lower addresses to the right): 85 // The layout of the frame is (lower addresses to the right):
86 // | spill slots | outgoing arguments | saved registers | 86 // | spill slots | outgoing arguments | saved registers |
87 // |XXXXXXXXXXXXX|--------------------|XXXXXXXXXXXXXXXXX| 87 // |XXXXXXXXXXXXX|--------------------|XXXXXXXXXXXXXXXXX|
88 // 88 //
89 // The splill slots and any saved registers are described in the stack 89 // The spill slots and any saved registers are described in the stack
90 // map. The outgoing arguments are assumed to be tagged; the number 90 // map. The outgoing arguments are assumed to be tagged; the number
91 // of outgoing arguments is not explicitly tracked. 91 // of outgoing arguments is not explicitly tracked.
92 // 92 //
93 // TODO(kmillikin): This does not handle slow path calls with 93 // TODO(kmillikin): This does not handle slow path calls with
94 // arguments, where the arguments are pushed after the live registers. 94 // arguments, where the arguments are pushed after the live registers.
95 // Enable such calls. 95 // Enable such calls.
96 intptr_t length = map.Length(); 96 intptr_t length = map.Length();
97 // Spill slots are at the 'bottom' of the frame. 97 // Spill slots are at the 'bottom' of the frame.
98 intptr_t spill_slot_count = length - map.RegisterBitCount(); 98 intptr_t spill_slot_count = length - map.RegisterBitCount();
99 for (intptr_t bit = 0; bit < spill_slot_count; ++bit) { 99 for (intptr_t bit = 0; bit < spill_slot_count; ++bit) {
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 if (deopt_instr->kind() == DeoptInstr::kCallerFp) { 428 if (deopt_instr->kind() == DeoptInstr::kCallerFp) {
429 return index; 429 return index;
430 } 430 }
431 } 431 }
432 UNREACHABLE(); 432 UNREACHABLE();
433 return 0; 433 return 0;
434 } 434 }
435 435
436 436
437 } // namespace dart 437 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/raw_object.cc ('k') | runtime/vm/visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698