Simple Cache: Turn some DCHECKs into CHECKs

Simple Cache: Turn some DCHECKs into CHECKs

We're trying to chase down http://crbug.com/317138.  Make some relevant
DCHECKs into CHECKs in hopes of an earlier crash.

BUG=317138
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235808

[Deprecated (see juliatuttle), 2013-11-14 18:27:22]

PTAL, pasko or gavinp.

[pasko, 2013-11-14 18:42:22]

That's a good idea, given it will be removed before going to Beta. Can you put
TODOs to remove it?

[pasko, 2013-11-14 18:43:25]

On 2013/11/14 18:42:22, pasko wrote:
> That's a good idea, given it will be removed before going to Beta. Can you put
> TODOs to remove it?

err, I mean, remove -> revert back to dcheck.

[Deprecated (see juliatuttle), 2013-11-16 01:18:18]

Added TODOs.  Running through trybots to make sure the CHECKs don't trip
already. :)

[cbentzel, 2013-11-16 02:42:49]

TODOs can get forgotten. Recommend adding a calendar event to clear it out.

On Fri, Nov 15, 2013 at 8:18 PM,  <ttuttle@chromium.org> wrote:
> Added TODOs.  Running through trybots to make sure the CHECKs don't trip
> already. :)
>
> https://codereview.chromium.org/70183004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cbentzel, 2013-11-16 14:08:05]

I'll wait for pasko or gavinp to give stamp of approval, but this seems like a
good change to me.

[gavinp, 2013-11-18 01:53:24]

lgtm.

[commit-bot: I haz the power, 2013-11-18 17:51:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ttuttle@chromium.org/70183004/60001

[commit-bot: I haz the power, 2013-11-18 20:38:24]

Change committed as 235808