Separate out Touch Selection Orientation enum

content/browser/android/popup_touch_handle_drawable.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/popup_touch_handle_drawable.h"
 
 #include "jni/PopupTouchHandleDrawable_jni.h"
 
 namespace content {
 
@@ skipping 13 matching lines @@
     Java_PopupTouchHandleDrawable_show(env, drawable_.obj());
   else
     Java_PopupTouchHandleDrawable_hide(env, drawable_.obj());
 }
 
 void PopupTouchHandleDrawable::SetOrientation(
     TouchHandleOrientation orientation) {
   JNIEnv* env = base::android::AttachCurrentThread();
   jobject obj = drawable_.obj();
   switch (orientation) {
     case TOUCH_HANDLE_LEFT:

[jdduke (slow), 2014/11/04 16:21:50]

No need for the switch here, let's just remove it and have:

Java_PopupTouchHandleDrawable_setOrientation(env, drawable_.obj(), orientation);

[AviD, 2014/11/04 18:24:32]

Done.

-      Java_PopupTouchHandleDrawable_setLeftOrientation(env, obj);
-      break;
-
     case TOUCH_HANDLE_RIGHT:
-      Java_PopupTouchHandleDrawable_setRightOrientation(env, obj);
-      break;
-
     case TOUCH_HANDLE_CENTER:
-      Java_PopupTouchHandleDrawable_setCenterOrientation(env, obj);
+      Java_PopupTouchHandleDrawable_setOrientation(env, obj, orientation);
       break;
 
     case TOUCH_HANDLE_ORIENTATION_UNDEFINED:
       NOTREACHED() << "Invalid touch handle orientation.";
   };
 }
 
 void PopupTouchHandleDrawable::SetAlpha(float alpha) {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_PopupTouchHandleDrawable_setOpacity(env, drawable_.obj(), alpha);
@@ skipping 21 matching lines @@
                                                       rect_pix.width(),
                                                       rect_pix.height());
 }
 
 // static
 bool PopupTouchHandleDrawable::RegisterPopupTouchHandleDrawable(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content