Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 701803002: Convert fast/multicol/vertical-[lr, rl]/rules-with-border-before to reftest. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/vertical-[lr, rl]/rules-with-border-before to reftest. Added DOCTYPE and described pass conditions. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184910

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename .[left,right] to .[before, after], where appropriate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -41 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html View 1 1 chunk +11 lines, -9 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/rules-with-border-before-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/vertical-lr/rules-with-border-before-expected.png View Binary file 0 comments Download
D LayoutTests/fast/multicol/vertical-lr/rules-with-border-before-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/rules-with-border-before.html View 1 1 chunk +10 lines, -8 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/rules-with-border-before-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/vertical-rl/rules-with-border-before-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/rules-with-border-before-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/rules-with-border-before-expected.png View Binary file 0 comments Download

Messages

Total messages: 6 (1 generated)
andersr
6 years, 1 month ago (2014-11-04 11:08:04 UTC) #1
mstensho (USE GERRIT)
lgtm with nit that applies to both tests. https://codereview.chromium.org/701803002/diff/1/LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html File LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html (right): https://codereview.chromium.org/701803002/diff/1/LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html#newcode12 LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html:12: .left ...
6 years, 1 month ago (2014-11-04 21:47:47 UTC) #2
andersr
https://codereview.chromium.org/701803002/diff/1/LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html File LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html (right): https://codereview.chromium.org/701803002/diff/1/LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html#newcode12 LayoutTests/fast/multicol/vertical-lr/rules-with-border-before.html:12: .left { -webkit-border-before: 50px solid blue; } On 2014/11/04 ...
6 years, 1 month ago (2014-11-06 11:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701803002/20001
6 years, 1 month ago (2014-11-06 11:34:02 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 12:35:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184910

Powered by Google App Engine
This is Rietveld 408576698