Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 7018002: Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>) (Closed)

Created:
8 years, 3 months ago by dcheng
Modified:
8 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/742/
Visibility:
Public.

Description

Merge 85971 - https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>) REGRESSION (r81684?): cox.com sign in button is missing Reviewed by Dan Bernstein. Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight. This restores the original behavior before the refactoring messed it up. Source/WebCore: Added fast/inline/nested-top-alignment.html * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): LayoutTests: * fast/inline/nested-top-alignment.html: Added. * platform/mac/fast/inline/nested-top-alignment-expected.png: Added. * platform/mac/fast/inline/nested-top-alignment-expected.txt: Added. TBR=levin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A + LayoutTests/fast/inline/nested-top-alignment.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/fast/inline/nested-top-alignment-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/fast/inline/nested-top-alignment-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
8 years, 3 months ago (2011-05-14 18:15:04 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698