Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 701753002: [WebSocket] Remove "Threadable" from class names. (Closed)

Created:
6 years, 1 month ago by yhirano
Modified:
6 years, 1 month ago
CC:
blink-reviews, yhirano+watch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[WebSocket] Remove "Threadable" from class names. "Threadable" in class names came from core/loader (e.g. ThreadableLoader), but it doesn't have any meaning in modules/websockets. This CL drops that adjective from class names. R=tyoshino,mkwst BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184835

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -689 lines) Patch
M Source/modules/modules.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketChannel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/modules/websockets/WorkerThreadableWebSocketChannel.h View 1 chunk +0 lines, -170 lines 0 comments Download
D Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 chunk +0 lines, -482 lines 0 comments Download
A + Source/modules/websockets/WorkerWebSocketChannel.h View 1 6 chunks +12 lines, -12 lines 0 comments Download
A + Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 7 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
yhirano
6 years, 1 month ago (2014-11-04 07:14:53 UTC) #2
tyoshino (SeeGerritForStatus)
lgtm
6 years, 1 month ago (2014-11-04 16:51:15 UTC) #3
tyoshino (SeeGerritForStatus)
+mkwst for modules.gypi
6 years, 1 month ago (2014-11-04 16:52:28 UTC) #7
Mike West
gypi LGTM
6 years, 1 month ago (2014-11-04 16:52:59 UTC) #8
tyoshino (SeeGerritForStatus)
nevermind. it doesn't require owners review.
6 years, 1 month ago (2014-11-04 16:52:59 UTC) #9
tyoshino (SeeGerritForStatus)
On 2014/11/04 16:52:59, Mike West wrote: > gypi LGTM Wow. So quick :) Thanks.
6 years, 1 month ago (2014-11-04 16:53:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701753002/20001
6 years, 1 month ago (2014-11-04 16:53:32 UTC) #12
Mike West
On 2014/11/04 16:52:59, tyoshino wrote: > nevermind. it doesn't require owners review. LGTM anyway. ;)
6 years, 1 month ago (2014-11-04 16:53:36 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 19:22:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184835

Powered by Google App Engine
This is Rietveld 408576698