Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 70173007: Added additional logging for strange error messages. (Closed)

Created:
7 years, 1 month ago by ygorshenin1
Modified:
7 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Added additional logging for strange error messages. BUG=263527 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235819

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
ygorshenin1
7 years, 1 month ago (2013-11-15 23:55:34 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/70173007/diff/1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right): https://codereview.chromium.org/70173007/diff/1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc#newcode143 chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:143: LOG(ERROR) << "CoreOobeHandler::ShowSignInError: error_text=" << error_text; This should ...
7 years, 1 month ago (2013-11-16 00:26:16 UTC) #2
ygorshenin1
https://codereview.chromium.org/70173007/diff/1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right): https://codereview.chromium.org/70173007/diff/1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc#newcode143 chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:143: LOG(ERROR) << "CoreOobeHandler::ShowSignInError: error_text=" << error_text; It doesn't matter, ...
7 years, 1 month ago (2013-11-16 00:43:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/70173007/1
7 years, 1 month ago (2013-11-18 19:25:42 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 21:31:47 UTC) #5
Message was sent while issue was closed.
Change committed as 235819

Powered by Google App Engine
This is Rietveld 408576698