content/renderer/render_frame_impl.cc - Issue 701713003: Support embedded plugins with MimeHandlerView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 701713003: Support embedded plugins with MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-guest-view-container

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/renderer/content_renderer_client.cc ('k') | extensions/renderer/guest_view/mime_handler_view_container.h » ('j') | extensions/renderer/guest_view/mime_handler_view_container.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 61734ff3af5e0b4306185837c97a34f5452cbaa2..092f9e27f63faf245bf0b311443992d0d77439f5 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1618,7 +1618,7 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(

if (base::UTF16ToUTF8(params.mimeType) == kBrowserPluginMimeType) {

scoped_ptr<BrowserPluginDelegate> browser_plugin_delegate(

GetContentClient()->renderer()->CreateBrowserPluginDelegate(this,

- kBrowserPluginMimeType));

+ kBrowserPluginMimeType, GURL(params.url)));

return render_view_->GetBrowserPluginManager()->CreateBrowserPlugin(

render_view_.get(), frame, browser_plugin_delegate.Pass());

}

@@ -1636,7 +1636,7 @@ blink::WebPlugin* RenderFrameImpl::createPlugin(

if (info.type == content::WebPluginInfo::PLUGIN_TYPE_BROWSER_PLUGIN) {

scoped_ptr<BrowserPluginDelegate> browser_plugin_delegate(

GetContentClient()->renderer()->CreateBrowserPluginDelegate(

- this, base::UTF16ToUTF8(params.mimeType)));

+ this, mime_type, GURL(params.url)));

return render_view_->GetBrowserPluginManager()->CreateBrowserPlugin(

render_view_.get(), frame, browser_plugin_delegate.Pass());

}