Support embedded plugins with MimeHandlerView.

Support embedded plugins with MimeHandlerView.

This change adds support for embedded plugins getting loaded via MimeHandlerView.
Changes:
-Changes MimeHandlerViewContainer to kick off a URL request when the content
is embedded. This is done because in that case, a URL request isn't started
automatically by the browser.
-Plumb through the original URL that is used to instantiate the plugin so that it can be loaded (as above).
-Change the extensions PluginManager to allow extensions that are associated
with a MIME type to be handlers for the file extensions which correspond with
that MIME type. This is needed because <embed>ed documents don't typically
specify a MIME type.

Currently the URL request made won't correctly be intercepted as an http stream. This change will be made in a followup CL.

BUG=303491
Committed: https://crrev.com/9765493708d63e233b77a1849c0aa399407be292
Cr-Commit-Position: refs/heads/master@{#303152}

[raymes, 2014-11-05 01:13:41]

raymes@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-11-05 09:16:31]

lgtm + nits.

https://codereview.chromium.org/701713003/diff/40001/extensions/renderer/gues...
File extensions/renderer/guest_view/mime_handler_view_container.cc (right):

https://codereview.chromium.org/701713003/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view_container.cc:27:
loader_->cancel();
I worry that if we don't get to Ready for whatever reason, then this will crash.
Can we add a NULL check here?

https://codereview.chromium.org/701713003/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view_container.cc:72: html_string_
+= std::string(data, data_length);
didReceiveData, and DidReceiveData. DidFinishLoading and didFinishLoading. A
comment would be really helpful here to explain the difference between these
code paths! Thanks!

[raymes, 2014-11-06 00:53:33]

raymes@chromium.org changed reviewers:
+ davidben@chromium.org, thestig@chromium.org, yoz@chromium.org

[raymes, 2014-11-06 00:53:34]

Thanks!

+OWNERS
thestig:
  chrome/renderer/chrome_content_renderer_client.cc
  chrome/renderer/chrome_content_renderer_client.h

yoz:
  chrome/browser/extensions/plugin_manager.cc
  extensions/shell/renderer/shell_content_renderer_client.cc
  extensions/shell/renderer/shell_content_renderer_client.h

davidben:
  content/public/renderer/content_renderer_client.cc
  content/public/renderer/content_renderer_client.h
  content/renderer/render_frame_impl.c

https://codereview.chromium.org/701713003/diff/40001/extensions/renderer/gues...
File extensions/renderer/guest_view/mime_handler_view_container.cc (right):

https://codereview.chromium.org/701713003/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view_container.cc:27:
loader_->cancel();
On 2014/11/05 09:16:31, Fady Samuel wrote:
> I worry that if we don't get to Ready for whatever reason, then this will
crash.
> Can we add a NULL check here?

Done.

https://codereview.chromium.org/701713003/diff/40001/extensions/renderer/gues...
extensions/renderer/guest_view/mime_handler_view_container.cc:72: html_string_
+= std::string(data, data_length);
On 2014/11/05 09:16:31, Fady Samuel wrote:
> didReceiveData, and DidReceiveData. DidFinishLoading and didFinishLoading. A
> comment would be really helpful here to explain the difference between these
> code paths! Thanks!

Done.

[Lei Zhang, 2014-11-06 01:03:52]

chrome/renderer/chrome_content_renderer_client.* lgtm

[Yoyo Zhou, 2014-11-06 01:08:47]

LGTM for extensions

[davidben, 2014-11-06 15:34:59]

content lgtm

[raymes, 2014-11-06 22:29:53]

The CQ bit was checked by raymes@chromium.org

[raymes, 2014-11-06 22:29:56]

The CQ bit was unchecked by raymes@chromium.org

[raymes, 2014-11-06 23:28:23]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2014-11-06 23:30:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/701713003/60001

[commit-bot: I haz the power, 2014-11-07 01:26:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-07 01:27:42]

Patchset 4 (id:??) landed as
https://crrev.com/9765493708d63e233b77a1849c0aa399407be292
Cr-Commit-Position: refs/heads/master@{#303152}