Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 701683002: Revert of Added orphaned compiled Python file checks. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
dnj, iannucci, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Revert of Added orphaned compiled Python file checks. (patchset #2 id:20001 of https://codereview.chromium.org/621533002/) Reason for revert: Makes `git cl upload` very slow in chrome checkouts. Original issue's description: > Added orphaned compiled Python file checks. > > There have been a handful of cases where orphaned compiled Python files (.pyc > files without an accompanying .py file) have been loaded preferentially by > the presubmit scripts, causing weird problems. This adds a check and a mode for > such files, either warning the user or deleting them. > > BUG=None > TEST=local > - Tested against local repository. > > R=iannucci@chromium.org, szager@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292703 TBR=iannucci@chromium.org,szager@chromium.org,dnj@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -141 lines) Patch
M presubmit_support.py View 5 chunks +2 lines, -48 lines 0 comments Download
M tests/presubmit_unittest.py View 8 chunks +1 line, -93 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of Added orphaned compiled Python file checks.
6 years, 1 month ago (2014-11-04 00:11:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701683002/1
6 years, 1 month ago (2014-11-04 00:11:54 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:13:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292818

Powered by Google App Engine
This is Rietveld 408576698