Issue 701673002: Subzero: Implement switch lowering for i64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 701673002: Subzero: Implement switch lowering for i64. (Closed)

Created:
6 years, 1 month ago by Jim Stichnoth

Modified:
6 years, 1 month ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Subzero: Implement switch lowering for i64. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2daadb78505b9909becfd3816173bacde9ab2384

Patch Set 2 : Remove RUIN line #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -3 lines)			Patch
	M	src/IceTargetLoweringX8632.cpp	View		1 chunk	+26 lines, -2 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/switch-opt.ll	View	1	2 chunks	+65 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

This was responsible for an assertion failure with pnacl-llc.pexe. https://codereview.chromium.org/701673002/diff/1/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (left): https://codereview.chromium.org/701673002/diff/1/src/IceTargetLoweringX8632.cpp#oldcode4036 src/IceTargetLoweringX8632.cpp:4036: ...

6 years, 1 month ago (2014-11-03 23:26:04 UTC) #2

Jim Stichnoth

6 years, 1 month ago (2014-11-04 03:57:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2daadb78505b9909becfd3816173bacde9ab2384 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 701673002: Subzero: Implement switch lowering for i64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove RUIN line #

Messages