Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 70163008: Fix newlib build for iconv so that we support UTF-16LE and UCS-4LE. (Closed)

Created:
7 years, 1 month ago by JF
Modified:
7 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix newlib build for iconv so that we support UTF-16LE and UCS-4LE. R=dschuff@chromium.org TEST= ./scons run_iconv_test -j32 bitcode=1 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pnacl/build.sh View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
JF
7 years, 1 month ago (2013-11-13 23:23:52 UTC) #1
JF
Actually it looks like the new additions are "free" space-wise, so we may as well ...
7 years, 1 month ago (2013-11-13 23:39:43 UTC) #2
JF
On 2013/11/13 23:39:43, JF wrote: > Actually it looks like the new additions are "free" ...
7 years, 1 month ago (2013-11-14 03:22:08 UTC) #3
Derek Schuff
build.sh LGTM, also adding Roland to make sure he knows too
7 years, 1 month ago (2013-11-14 17:01:55 UTC) #4
JF
7 years, 1 month ago (2013-11-14 17:07:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r12389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698