Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 70163006: MIPS: Simplify behavior of code stubs that accept a variable number of stack arguments in addition … (Closed)

Created:
7 years, 1 month ago by kilvadyb
Modified:
7 years, 1 month ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Simplify behavior of code stubs that accept a variable number of stack arguments in addition to their parameters. Port r17680 (cc0b972) Original commit message: Before, we'd add a special variable to the environment with the value of a register with the number of arguments. Now, that register just appears as a parameter to the code stub. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M src/mips/code-stubs-mips.cc View 2 chunks +22 lines, -9 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
lgtm
7 years, 1 month ago (2013-11-13 15:05:01 UTC) #1
kilvadyb
7 years, 1 month ago (2013-11-13 18:17:04 UTC) #2
Paul Lind
7 years, 1 month ago (2013-11-13 18:24:33 UTC) #3
Committed as r17710.

Powered by Google App Engine
This is Rietveld 408576698