Source/core/rendering/compositing/CompositedLayerMapping.cpp - Issue 70163005: Fix clientLeft value for RTL direction, while the element have vertical scrollbar in left side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 70163005: Fix clientLeft value for RTL direction, while the element have vertical scrollbar in left side. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp

diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp

index 352a2c2eb93b04ef501000dfca5aa714af09251e..54a1db032a310c8db3ad9e1f1cae26687af5fff4 100644

--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp

+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp

@@ -798,9 +798,6 @@ void CompositedLayerMapping::updateGraphicsLayerGeometry()

ASSERT(m_scrollingContentsLayer);

RenderBox* renderBox = toRenderBox(renderer());

IntRect clientBox = enclosingIntRect(renderBox->clientBoxRect());

- // FIXME: We should make RenderBox::clientBoxRect consider scrollbar placement.

- if (style->shouldPlaceBlockDirectionScrollbarOnLogicalLeft())

- clientBox.move(renderBox->verticalScrollbarWidth(), 0);

IntSize adjustedScrollOffset = m_owningLayer->scrollableArea()->adjustedScrollOffset();

m_scrollingLayer->setPosition(FloatPoint(clientBox.location() - localCompositingBounds.location() + roundedIntSize(m_subpixelAccumulation)));

« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | no next file » | no next file with comments »