Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: chrome/browser/search_engines/template_url_unittest.cc

Issue 70163003: Try to fix flaky test TemplateURLTest.ReplacePageClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_unittest.cc b/chrome/browser/search_engines/template_url_unittest.cc
index 57d09087d61f9f3f26862dc354bf6404b2fe42e8..bcad78a7748a879b8da28fb2d5ee2472d549d758 100644
--- a/chrome/browser/search_engines/template_url_unittest.cc
+++ b/chrome/browser/search_engines/template_url_unittest.cc
@@ -1208,12 +1208,8 @@ TEST_F(TemplateURLTest, ExtraQueryParams) {
}
// Tests replacing pageClassification.
-#if defined(OS_ANDROID)
-#define MAYBE_ReplacePageClassification DISABLED_ReplacePageClassification
-#else
-#define MAYBE_ReplacePageClassification ReplacePageClassification
-#endif
-TEST_F(TemplateURLTest, MAYBE_ReplacePageClassification) {
+TEST_F(TemplateURLTest, ReplacePageClassification) {
+ UIThreadSearchTermsData::SetGoogleBaseURL("http://www.google.com/");
TemplateURLData data;
data.input_encodings.push_back("UTF-8");
data.SetURL("{google:baseURL}?{google:pageClassification}q={searchTerms}");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698