Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3286)

Unified Diff: chrome/browser/chromeos/cros/network_library.cc

Issue 7016046: Merge 85338 - Really fix chromium-os:14180 this time. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/742/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/network_library.cc
===================================================================
--- chrome/browser/chromeos/cros/network_library.cc (revision 85369)
+++ chrome/browser/chromeos/cros/network_library.cc (working copy)
@@ -3290,6 +3290,8 @@
std::pair<NetworkMap::iterator,bool> result =
network_map_.insert(std::make_pair(network->service_path(), network));
DCHECK(result.second); // Should only get called with new network.
+ VLOG(2) << "Adding Network: " << network->service_path()
+ << " (" << network->name() << ")";
ConnectionType type(network->type());
if (type == TYPE_WIFI) {
if (wifi_enabled())
@@ -3461,8 +3463,10 @@
// Request the active profile which lists the remembered networks.
void RequestRememberedNetworksUpdate() {
- RequestNetworkProfile(
- active_profile_path_.c_str(), &ProfileUpdate, this);
+ if (!active_profile_path_.empty()) {
+ RequestNetworkProfile(
+ active_profile_path_.c_str(), &ProfileUpdate, this);
+ }
}
// Update the list of remembered (profile) networks, and request associated
@@ -3643,15 +3647,9 @@
if (!device_path.empty()) {
NetworkDeviceMap::iterator found = old_device_map.find(device_path);
if (found != old_device_map.end()) {
- VLOG(2) << " Adding device: " << device_path;
+ VLOG(2) << " Adding existing device: " << device_path;
device_map_[device_path] = found->second;
old_device_map.erase(found);
- // Add device property monitor before we request the
- // full property list, to ensure that we won't miss any
- // property changes.
- network_device_observers_[device_path] =
- new NetworkDeviceObserverList(this, device_path);
-
}
RequestNetworkDeviceInfo(
device_path.c_str(), &NetworkDeviceUpdate, this);
@@ -3700,6 +3698,11 @@
device = new NetworkDevice(device_path);
VLOG(2) << " Adding device: " << device_path;
device_map_[device_path] = device;
+ if (network_device_observers_.find(device_path) ==
+ network_device_observers_.end()) {
+ network_device_observers_[device_path] =
+ new NetworkDeviceObserverList(this, device_path);
+ }
}
device->ParseInfo(info);
VLOG(1) << "ParseNetworkDevice:" << device->name();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698