Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 701583002: downloads/bookmarks: change <h2> to <h1> for better screen reader semantics. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, asanka, tfarina, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

downloads/bookmarks: change <h2> to <h1> for better screen reader semantics. R=dmazzoni@chromium.org BUG=428156 Committed: https://crrev.com/7c80e234132e8bbc67243542202b4b8a09e5da57 Cr-Commit-Position: refs/heads/master@{#302484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/bookmark_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/downloads/downloads.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/search_header.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
6 years, 1 month ago (2014-11-03 19:59:51 UTC) #1
dmazzoni
lgtm
6 years, 1 month ago (2014-11-03 20:19:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701583002/1
6 years, 1 month ago (2014-11-03 20:20:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 21:32:41 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 21:33:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c80e234132e8bbc67243542202b4b8a09e5da57
Cr-Commit-Position: refs/heads/master@{#302484}

Powered by Google App Engine
This is Rietveld 408576698