Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 701553002: Allow systematic prefix search in bookmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.cc
diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc
index 60e143caf4f38ccb184bca21ef82b37750874da4..5809cb2e1b9f6a4f285bf4c5999152adb8db3f54 100644
--- a/components/bookmarks/browser/bookmark_model.cc
+++ b/components/bookmarks/browser/bookmark_model.cc
@@ -689,14 +689,25 @@ void BookmarkModel::ResetDateFolderModified(const BookmarkNode* node) {
SetDateFolderModified(node, Time());
}
-void BookmarkModel::GetBookmarksMatching(
+void BookmarkModel::GetBookmarksMatching(const base::string16& text,
+ size_t max_count,
+ std::vector<BookmarkMatch>* matches) {
+ if (!loaded_)
+ return;
+
+ index_->GetBookmarksMatching(
+ text, max_count, false /* always_prefix_search */, matches);
+}
+
+void BookmarkModel::GetBookmarksMatchingPrefixes(
const base::string16& text,
size_t max_count,
std::vector<BookmarkMatch>* matches) {
if (!loaded_)
return;
- index_->GetBookmarksMatching(text, max_count, matches);
+ index_->GetBookmarksMatching(
+ text, max_count, true /* always_prefix_search */, matches);
sky 2014/11/03 21:44:05 I'm not a fan of this style. It's a good indicatio
Kibeom Kim (inactive) 2014/11/04 01:28:19 Done.
}
void BookmarkModel::ClearStore() {

Powered by Google App Engine
This is Rietveld 408576698