Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/ast.h

Issue 701533002: Fix uninitialized fields in the BinaryOperation ast node. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_AST_H_ 5 #ifndef V8_AST_H_
6 #define V8_AST_H_ 6 #define V8_AST_H_
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 2076 matching lines...) Expand 10 before | Expand all | Expand 10 after
2087 } 2087 }
2088 2088
2089 virtual void RecordToBooleanTypeFeedback( 2089 virtual void RecordToBooleanTypeFeedback(
2090 TypeFeedbackOracle* oracle) OVERRIDE; 2090 TypeFeedbackOracle* oracle) OVERRIDE;
2091 2091
2092 protected: 2092 protected:
2093 BinaryOperation(Zone* zone, Token::Value op, Expression* left, 2093 BinaryOperation(Zone* zone, Token::Value op, Expression* left,
2094 Expression* right, int pos) 2094 Expression* right, int pos)
2095 : Expression(zone, pos), 2095 : Expression(zone, pos),
2096 op_(static_cast<byte>(op)), 2096 op_(static_cast<byte>(op)),
2097 has_fixed_right_arg_(false),
2098 fixed_right_arg_value_(0),
2097 left_(left), 2099 left_(left),
2098 right_(right) { 2100 right_(right) {
2099 DCHECK(Token::IsBinaryOp(op)); 2101 DCHECK(Token::IsBinaryOp(op));
2100 } 2102 }
2101 static int parent_num_ids() { return Expression::num_ids(); } 2103 static int parent_num_ids() { return Expression::num_ids(); }
2102 2104
2103 private: 2105 private:
2104 int local_id(int n) const { return base_id() + parent_num_ids() + n; } 2106 int local_id(int n) const { return base_id() + parent_num_ids() + n; }
2105 2107
2106 const byte op_; // actually Token::Value 2108 const byte op_; // actually Token::Value
(...skipping 1536 matching lines...) Expand 10 before | Expand all | Expand 10 after
3643 private: 3645 private:
3644 Zone* zone_; 3646 Zone* zone_;
3645 Visitor visitor_; 3647 Visitor visitor_;
3646 AstValueFactory* ast_value_factory_; 3648 AstValueFactory* ast_value_factory_;
3647 }; 3649 };
3648 3650
3649 3651
3650 } } // namespace v8::internal 3652 } } // namespace v8::internal
3651 3653
3652 #endif // V8_AST_H_ 3654 #endif // V8_AST_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698