Issue 701513002: Don't double-check elements in the prototype chain in array builtins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 701513002: Don't double-check elements in the prototype chain in array builtins (Closed)

Created:
6 years, 1 month ago by Toon Verwaest

Modified:
6 years, 1 month ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Don't double-check elements in the prototype chain in array builtins BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25076

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -30 lines)			Patch
	M	src/builtins.cc	View		7 chunks	+19 lines, -27 lines	1 comment	Download
	M	test/mjsunit/array-natives-elements.js	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mvstanton

lgtm https://codereview.chromium.org/701513002/diff/1/src/builtins.cc File src/builtins.cc (left): https://codereview.chromium.org/701513002/diff/1/src/builtins.cc#oldcode528 src/builtins.cc:528: DONT_ALLOW_DOUBLE_ELEMENTS); nit: should prolly be in another CL ...

6 years, 1 month ago (2014-11-03 12:59:13 UTC) #3

Toon Verwaest

6 years, 1 month ago (2014-11-03 14:06:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25076 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages