Issue 7015022: 'emails' can be unicode when in production.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7015022: 'emails' can be unicode when in production. (Closed)

Created:
9 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Visibility:
Public.

Description

'emails' can be unicode when in production. Add manual conversion so it doesn't throw an exception. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85177

Patch Set 2 : include more fixes #

Patch Set 4 : of of of #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	verification/try_server.py	View	1 2 3	5 chunks	+22 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. http://codereview.chromium.org/7015022/diff/4002/verification/try_server.py File verification/try_server.py (right): http://codereview.chromium.org/7015022/diff/4002/verification/try_server.py#newcode297 verification/try_server.py:297: logging.info('Fetching all try jobs status because of of ...

9 years, 7 months ago (2011-05-12 20:29:41 UTC) #2

Change committed as 85177