Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 7015007: Use GetXDisplay() instead of XOpenDisplay() in IdleQueryLinux. (Closed)

Created:
9 years, 7 months ago by dcheng
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use GetXDisplay() instead of XOpenDisplay() in IdleQueryLinux. We weren't checking that XOpenDisplay was actually succeeding before attempting to use the display. BUG=82308 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M chrome/browser/idle_query_linux.cc View 4 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
9 years, 7 months ago (2011-05-11 21:00:37 UTC) #1
Evan Stade
Looks ok to me, but zork is the original author
9 years, 7 months ago (2011-05-11 21:06:35 UTC) #2
Zachary Kuznia
9 years, 7 months ago (2011-05-12 09:08:15 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698