Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 701493002: Merge 183455 "Focus unfocusable node upon reference fragment nav..." (Closed)

Created:
6 years, 1 month ago by robwu
Modified:
6 years, 1 month ago
Reviewers:
robwu
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Merge 183455 "Focus unfocusable node upon reference fragment nav..." > Focus unfocusable node upon reference fragment navigation > > Currently, when the page navigates to a non-focusable reference fragment, > the currently focused element does not change. In Firefox/IE, the focus is > moved to the referenced element even when this element is non-focusable. > > This mismatch in behavior became apparent when Blink started supporting > a:focus (https://crbug.com/388666). In IE/FF, clicking on <a href="#ref"> > causes the link to loose focus, and therefore :focus does not get applied > any more. In Chrome, however, :focus remains activated because the focus > does not change. > > This patch changes the behavior of Blink: When the pages navigates to a > reference fragment that refers to a non-focusable node, then the focus > is removed from the previously focused element. > > See also https://www.w3.org/Bugs/Public/show_bug.cgi?id=26907. > > BUG=417636, 262171 > TEST=Tools/Scripts/run-webkit-tests fast/dom/fragment-activation-focuses-target.html > > Review URL: https://codereview.chromium.org/637323002 TBR=rob@robwu.nl Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M LayoutTests/fast/dom/fragment-activation-focuses-target.html View 2 chunks +26 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/fragment-activation-focuses-target-expected.txt View 1 chunk +12 lines, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
robwu
6 years, 1 month ago (2014-11-03 10:19:46 UTC) #1
robwu
6 years, 1 month ago (2014-11-03 10:22:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r184786.

Powered by Google App Engine
This is Rietveld 408576698