Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 701483002: [chrome/browser/translate, chrome/browser/thumbnails] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
droger, Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chrome/browser/translate, chrome/browser/thumbnails] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/c92ea240eb84f4bae2a350b3e5c6d3abb7935654 Cr-Commit-Position: refs/heads/master@{#302779}

Patch Set 1 #

Patch Set 2 : Fixed indentations #

Total comments: 1

Patch Set 3 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/thumbnails/thumbnail_tab_helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/component_cld_data_harness.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/translate/standalone_cld_data_harness.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-03 12:54:54 UTC) #2
sky
And another.
6 years, 1 month ago (2014-11-03 16:32:01 UTC) #4
anujsharma
thestig@chromium.org: Please review changes in chrome/browser
6 years, 1 month ago (2014-11-04 04:57:45 UTC) #7
droger
translate lgtm
6 years, 1 month ago (2014-11-04 10:00:36 UTC) #8
anujsharma
On 2014/11/04 10:00:36, droger wrote: > translate lgtm Thanks droger for lgtm. @Lei, could you ...
6 years, 1 month ago (2014-11-05 04:27:37 UTC) #9
Lei Zhang
Your commit message is not fully accurate. https://codereview.chromium.org/701483002/diff/20001/chrome/browser/translate/standalone_cld_data_harness.cc File chrome/browser/translate/standalone_cld_data_harness.cc (right): https://codereview.chromium.org/701483002/diff/20001/chrome/browser/translate/standalone_cld_data_harness.cc#newcode73 chrome/browser/translate/standalone_cld_data_harness.cc:73: << target_file.value(); ...
6 years, 1 month ago (2014-11-05 06:01:16 UTC) #10
anujsharma
On 2014/11/05 06:01:16, Lei Zhang wrote: > Your commit message is not fully accurate. > ...
6 years, 1 month ago (2014-11-05 06:26:57 UTC) #11
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-05 09:13:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701483002/40001
6 years, 1 month ago (2014-11-05 09:14:35 UTC) #14
anujsharma
On 2014/11/05 09:13:28, Lei Zhang wrote: > lgtm Thanks Lei for lgtm.
6 years, 1 month ago (2014-11-05 10:10:30 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8788)
6 years, 1 month ago (2014-11-05 10:21:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701483002/40001
6 years, 1 month ago (2014-11-05 10:34:45 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-05 11:36:00 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 11:36:34 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c92ea240eb84f4bae2a350b3e5c6d3abb7935654
Cr-Commit-Position: refs/heads/master@{#302779}

Powered by Google App Engine
This is Rietveld 408576698