Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 701463003: Cleanup #include in //components/keyed_service/content (Closed)

Created:
6 years, 1 month ago by sdefresne
Modified:
6 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@419366.a
Project:
chromium
Visibility:
Public.

Description

Cleanup #include in //components/keyed_service/content Remove unnecessary #includes from //components/keyed_service/content after recent refactoring. BUG=419366 Committed: https://crrev.com/b65065375e0d1c6f81bacebee75ed1176502243f Cr-Commit-Position: refs/heads/master@{#302631}

Patch Set 1 #

Patch Set 2 : Remove another #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M components/keyed_service/content/browser_context_dependency_manager.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/keyed_service/content/browser_context_keyed_service_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
PTAL
6 years, 1 month ago (2014-11-04 15:06:12 UTC) #2
Elliot Glaysher
lgtm
6 years, 1 month ago (2014-11-04 18:00:30 UTC) #3
Elliot Glaysher
lgtm lgtm
6 years, 1 month ago (2014-11-04 18:00:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701463003/20001
6 years, 1 month ago (2014-11-04 18:02:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 18:49:53 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 18:50:27 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b65065375e0d1c6f81bacebee75ed1176502243f
Cr-Commit-Position: refs/heads/master@{#302631}

Powered by Google App Engine
This is Rietveld 408576698