Issue 701463002: Add workdir feature to release scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 701463002: Add workdir feature to release scripts. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach

Modified:
6 years, 1 month ago

Reviewers:
tandrii(chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add workdir feature to release scripts. BUG=408523 LOG=n TEST=script_test.py TBR=tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25056

Patch Set 2 : #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
	M	tools/push-to-trunk/common_includes.py	View	1	5 chunks	+20 lines, -2 lines	2 comments	Download
	M	tools/push-to-trunk/test_scripts.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

Committed patchset #2 (id:20001) manually as 25056 (presubmit successful).

6 years, 1 month ago (2014-11-03 08:41:22 UTC) #3

Michael Achenbach

https://codereview.chromium.org/701463002/diff/20001/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/701463002/diff/20001/tools/push-to-trunk/common_includes.py#newcode611 tools/push-to-trunk/common_includes.py:611: def BootstrapV8Checkout(self): Doh - this method isn't even called ...

6 years, 1 month ago (2014-11-03 08:44:54 UTC) #4

Michael Achenbach

6 years, 1 month ago (2014-11-03 09:02:02 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/701463002/diff/20001/tools/push-to-trunk/comm...
File tools/push-to-trunk/common_includes.py (right):

https://codereview.chromium.org/701463002/diff/20001/tools/push-to-trunk/comm...
tools/push-to-trunk/common_includes.py:618: if not os.path.exits(work_dir):
exits??? sleepy...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 701463002: Add workdir feature to release scripts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages