Lazily allocate svg shape transforms, shrink RenderSVGShape by 44B

Source/core/rendering/svg/RenderSVGShape.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2005, 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * Copyright (C) 2011 University of Szeged
@@ skipping 105 matching lines @@
 
     if (m_needsShapeUpdate || m_needsBoundariesUpdate) {
         updateShapeFromElement();
         m_needsShapeUpdate = false;
         updatePaintInvalidationBoundingBox();
         m_needsBoundariesUpdate = false;
         updateCachedBoundariesInParents = true;
     }
 
     if (m_needsTransformUpdate) {
-        m_localTransform =  toSVGGraphicsElement(element())->calculateAnimatedLocalTransform();
+        SVGGraphicsElement* graphicsElement = toSVGGraphicsElement(element());
+        if (graphicsElement->hasAnimatedLocalTransform()) {

[pdr., 2014/11/07 04:21:33]

I'm not a huge fan of how this looks... do either of you have suggestions for
making this better?

[f(malita), 2014/11/07 18:23:12]

Not necessarily better, but if you want to optimize for legibility and willing
to eat up a double-initialization on allocation we could do

    if (!m_localTransform)
        m_localTransform = adoptPtr(new AffineTransform());
    *m_localTransform = graphicsElement->calculateAnimatedLocalTransform();

Up to you, I don't feel strongly either way.

[fs, 2014/11/10 11:36:43]

No greater suggestions here either. You could get rid of the double-init above
with a new AffineTransform constructor though - if it's felt to be a too large
sacrifice.

+            if (m_localTransform)
+                *m_localTransform = graphicsElement->calculateAnimatedLocalTransform();
+            else
+                m_localTransform = adoptPtr(new AffineTransform(graphicsElement->calculateAnimatedLocalTransform()));
+        } else {
+            m_localTransform = 0;
+        }
+
         m_needsTransformUpdate = false;
         updateCachedBoundariesInParents = true;
     }
 
     // Invalidate all resources of this client if our layout changed.
     if (everHadLayout() && selfNeedsLayout())
         SVGResourcesCache::clientLayoutChanged(this);
 
     // If our bounds changed, notify the parents.
     if (updateCachedBoundariesInParents)
@@ skipping 31 matching lines @@
         rects.append(rect);
 }
 
 bool RenderSVGShape::nodeAtFloatPoint(const HitTestRequest& request, HitTestResult& result, const FloatPoint& pointInParent, HitTestAction hitTestAction)
 {
     // We only draw in the foreground phase, so we only hit-test then.
     if (hitTestAction != HitTestForeground)
         return false;
 
     FloatPoint localPoint;
-    if (!SVGRenderSupport::transformToUserSpaceAndCheckClipping(this, m_localTransform, pointInParent, localPoint))
+    if (!SVGRenderSupport::transformToUserSpaceAndCheckClipping(this, localToParentTransform(), pointInParent, localPoint))
         return false;
 
     PointerEventsHitRules hitRules(PointerEventsHitRules::SVG_GEOMETRY_HITTESTING, request, style()->pointerEvents());
     if (nodeAtFloatPointInternal(request, localPoint, hitRules)) {
         updateHitTestResult(result, roundedLayoutPoint(localPoint));
         return true;
     }
 
     return false;
 }
@@ skipping 60 matching lines @@
 bool RenderSVGShape::hasSmoothStroke() const
 {
     const SVGRenderStyle& svgStyle = style()->svgStyle();
     return svgStyle.strokeDashArray()->isEmpty()
         && svgStyle.strokeMiterLimit() == SVGRenderStyle::initialStrokeMiterLimit()
         && svgStyle.joinStyle() == SVGRenderStyle::initialJoinStyle()
         && svgStyle.capStyle() == SVGRenderStyle::initialCapStyle();
 }
 
 }