Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 70143003: Add more test coverage to push-to-trunk script. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add more test coverage to push-to-trunk script. Ensure that fetching commits works with huge change logs. The verbosity option will help debugging when dcommit hangs. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17645

Patch Set 1 #

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 chunk +4 lines, -12 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 1 month ago (2013-11-12 10:28:03 UTC) #1
Jakob Kummerow
Here, I fixed that "cat: write error: Broken pipe" for you: def GetLastChangeLogEntries(change_log_file): result = ...
7 years, 1 month ago (2013-11-12 12:51:58 UTC) #2
Michael Achenbach
On 2013/11/12 12:51:58, Jakob wrote: > Here, I fixed that "cat: write error: Broken pipe" ...
7 years, 1 month ago (2013-11-12 13:10:59 UTC) #3
Michael Achenbach
7 years, 1 month ago (2013-11-12 13:11:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r17645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698