Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 70143002: Introduced IDR_SIGNIN_INTERNALS_INDEX_* strings to grit_whitelist.txt (Closed)

Created:
7 years, 1 month ago by pkl (ping after 24h if needed)
Modified:
7 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Visibility:
Public.

Description

Introduced IDR_SIGNIN_INTERNALS_INDEX_* strings to grit_whitelist.txt This is to enable chrome://signin-internals Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkl (ping after 24h if needed)
droger: This is the upstream change for making chrome:signin-internals work.
7 years, 1 month ago (2013-11-12 09:34:54 UTC) #1
droger
lgtm
7 years, 1 month ago (2013-11-12 11:53:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkl@chromium.org/70143002/1
7 years, 1 month ago (2013-11-12 11:59:01 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 14:03:56 UTC) #4
Message was sent while issue was closed.
Change committed as 234504

Powered by Google App Engine
This is Rietveld 408576698