Chromium Code Reviews
Help | Chromium Project | Sign in
(173)

Issue 7014009: Pass net_log parameter properly for ProxyResolvingClientSocket (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by akalin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Pass net_log parameter properly for ProxyResolvingClientSocket Also initialize a few more fields in the session_params object. Remove unused net_log params. BUG=82365 TEST=Turn on sync, look in chrome://sync-internals for entries for talk.google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85235

Patch Set 1 #

Total comments: 4

Messages

Total messages: 5 (0 generated)
akalin
+sanjeevr for review
4 years, 1 month ago (2011-05-12 00:29:07 UTC) #1
sanjeevr
http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode35 jingle/notifier/base/proxy_resolving_client_socket.cc:35: request_context_getter->GetURLRequestContext()->net_log(), I am presuming that passing NULL to BoundNetLog::Make ...
4 years, 1 month ago (2011-05-12 18:26:08 UTC) #2
akalin
+willchan to review session_params changes (by sanjeev's request) http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode35 jingle/notifier/base/proxy_resolving_client_socket.cc:35: request_context_getter->GetURLRequestContext()->net_log(), ...
4 years, 1 month ago (2011-05-12 18:45:42 UTC) #3
sanjeevr
LGTM for everything else.
4 years, 1 month ago (2011-05-12 20:48:47 UTC) #4
willchan no longer on Chromium
4 years, 1 month ago (2011-05-13 01:23:29 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d