Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 7014009: Pass net_log parameter properly for ProxyResolvingClientSocket (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by akalin
Modified:
2 years, 11 months ago
Reviewers:
sanjeevr, willchan
CC:
chromium-reviews_chromium.org, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Pass net_log parameter properly for ProxyResolvingClientSocket

Also initialize a few more fields in the session_params object.

Remove unused net_log params.

BUG=82365
TEST=Turn on sync, look in chrome://sync-internals for entries for talk.google.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85235

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -37 lines) Lint Patch
M jingle/notifier/base/chrome_async_socket.h View 3 chunks +2 lines, -6 lines 0 comments 0 errors Download
M jingle/notifier/base/chrome_async_socket.cc View 3 chunks +2 lines, -5 lines 0 comments 0 errors Download
M jingle/notifier/base/chrome_async_socket_unittest.cc View 5 chunks +3 lines, -8 lines 0 comments 0 errors Download
M jingle/notifier/base/proxy_resolving_client_socket.h View 1 chunk +1 line, -2 lines 0 comments 0 errors Download
M jingle/notifier/base/proxy_resolving_client_socket.cc View 3 chunks +9 lines, -3 lines 4 comments 0 errors Download
M jingle/notifier/base/proxy_resolving_client_socket_unittest.cc View 4 chunks +1 line, -5 lines 0 comments 0 errors Download
M jingle/notifier/base/resolving_client_socket_factory.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M jingle/notifier/base/xmpp_client_socket_factory.cc View 1 chunk +2 lines, -3 lines 0 comments 0 errors Download
M jingle/notifier/base/xmpp_connection.cc View 2 chunks +1 line, -3 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 5
akalin
+sanjeevr for review
2 years, 11 months ago #1
sanjeevr
http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode35 jingle/notifier/base/proxy_resolving_client_socket.cc:35: request_context_getter->GetURLRequestContext()->net_log(), I am presuming that passing NULL to BoundNetLog::Make ...
2 years, 11 months ago #2
akalin
+willchan to review session_params changes (by sanjeev's request) http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode35 jingle/notifier/base/proxy_resolving_client_socket.cc:35: request_context_getter->GetURLRequestContext()->net_log(), ...
2 years, 11 months ago #3
sanjeevr
LGTM for everything else.
2 years, 11 months ago #4
willchan
2 years, 11 months ago #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6