Chromium Code Reviews
Help | Chromium Project | Sign in
(79)

Issue 7014009: Pass net_log parameter properly for ProxyResolvingClientSocket (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by akalin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, PaweĊ‚ Hajdan Jr.
Visibility:
Public.

Description

Pass net_log parameter properly for ProxyResolvingClientSocket Also initialize a few more fields in the session_params object. Remove unused net_log params. BUG=82365 TEST=Turn on sync, look in chrome://sync-internals for entries for talk.google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85235

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -37 lines) Patch
M jingle/notifier/base/chrome_async_socket.h View 3 chunks +2 lines, -6 lines 0 comments Download
M jingle/notifier/base/chrome_async_socket.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M jingle/notifier/base/chrome_async_socket_unittest.cc View 5 chunks +3 lines, -8 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.h View 1 chunk +1 line, -2 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.cc View 3 chunks +9 lines, -3 lines 4 comments Download
M jingle/notifier/base/proxy_resolving_client_socket_unittest.cc View 4 chunks +1 line, -5 lines 0 comments Download
M jingle/notifier/base/resolving_client_socket_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M jingle/notifier/base/xmpp_connection.cc View 2 chunks +1 line, -3 lines 0 comments Download
Commit:

Messages

Total messages: 5 (0 generated)
akalin
+sanjeevr for review
3 years, 9 months ago (2011-05-12 00:29:07 UTC) #1
sanjeevr
http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode35 jingle/notifier/base/proxy_resolving_client_socket.cc:35: request_context_getter->GetURLRequestContext()->net_log(), I am presuming that passing NULL to BoundNetLog::Make ...
3 years, 9 months ago (2011-05-12 18:26:08 UTC) #2
akalin
+willchan to review session_params changes (by sanjeev's request) http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc File jingle/notifier/base/proxy_resolving_client_socket.cc (right): http://codereview.chromium.org/7014009/diff/1/jingle/notifier/base/proxy_resolving_client_socket.cc#newcode35 jingle/notifier/base/proxy_resolving_client_socket.cc:35: request_context_getter->GetURLRequestContext()->net_log(), ...
3 years, 9 months ago (2011-05-12 18:45:42 UTC) #3
sanjeevr
LGTM for everything else.
3 years, 9 months ago (2011-05-12 20:48:47 UTC) #4
willchan OOO until 04-22-15
3 years, 9 months ago (2011-05-13 01:23:29 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld dd99357-tainted