Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 701353004: [Most Visited] Only log impression metrics on initial NTP load. (Closed)

Created:
6 years, 1 month ago by Mathieu
Modified:
6 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Most Visited] Only log impression metrics on initial NTP load. The NTP view can refresh the data an arbitrary amount of times (due to changes in Top Sites, sync state, etc.). We observed that we can easily get the NTP to log impressions 10 times for a single NTP, just by staying on the page. This change limits the logging of impressions to the initial load of the NTP, to avoid biasing the data too heavily. I think this will more closely track what's going on. BUG=None TEST=Manual Committed: https://crrev.com/8e871c6242fb9efe9f62c9022b655bb8da78a032 Cr-Commit-Position: refs/heads/master@{#303077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M chrome/browser/android/most_visited_sites.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/most_visited_sites.cc View 3 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mathieu
Hi Newton, can you have a look?
6 years, 1 month ago (2014-11-06 18:46:36 UTC) #2
newt (away)
lgtm
6 years, 1 month ago (2014-11-06 19:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701353004/1
6 years, 1 month ago (2014-11-06 19:07:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 19:54:15 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 19:55:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e871c6242fb9efe9f62c9022b655bb8da78a032
Cr-Commit-Position: refs/heads/master@{#303077}

Powered by Google App Engine
This is Rietveld 408576698