Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 701243002: Fix JS errors for Cellular (Closed)

Created:
6 years, 1 month ago by stevenjb
Modified:
6 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix JS errors for Cellular Bugs in the JS code introduced while re-factoring are preventing the dialog from displaying correctly. BUG=430384 Committed: https://crrev.com/062c2cc8d00f3290ba788a1420349af8047515b4 Cr-Commit-Position: refs/heads/master@{#302922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M chrome/browser/resources/options/chromeos/internet_detail.html View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 3 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stevenjb
6 years, 1 month ago (2014-11-05 20:38:21 UTC) #2
Ben Chan
lgtm
6 years, 1 month ago (2014-11-05 22:24:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701243002/1
6 years, 1 month ago (2014-11-05 23:03:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 00:33:11 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 00:35:36 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/062c2cc8d00f3290ba788a1420349af8047515b4
Cr-Commit-Position: refs/heads/master@{#302922}

Powered by Google App Engine
This is Rietveld 408576698