Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 701233003: Implement bigint intrinsics on arm64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/disassembler_arm64.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_arm.cc
===================================================================
--- runtime/vm/intrinsifier_arm.cc (revision 41606)
+++ runtime/vm/intrinsifier_arm.cc (working copy)
@@ -906,14 +906,17 @@
// R2 = used, R3 = digits
__ ldrd(R2, Address(SP, 3 * kWordSize));
+ // R3 = &digits[0]
__ add(R3, R3, Operand(TypedData::data_offset() - kHeapObjectTag));
// R4 = a_used, R5 = a_digits
__ ldrd(R4, Address(SP, 1 * kWordSize));
+ // R5 = &a_digits[0]
__ add(R5, R5, Operand(TypedData::data_offset() - kHeapObjectTag));
// R6 = r_digits
__ ldr(R6, Address(SP, 0 * kWordSize));
+ // R6 = &r_digits[0]
__ add(R6, R6, Operand(TypedData::data_offset() - kHeapObjectTag));
// R7 = &digits[a_used >> 1], a_used is Smi.
@@ -963,14 +966,17 @@
// R2 = used, R3 = digits
__ ldrd(R2, Address(SP, 3 * kWordSize));
+ // R3 = &digits[0]
__ add(R3, R3, Operand(TypedData::data_offset() - kHeapObjectTag));
// R4 = a_used, R5 = a_digits
__ ldrd(R4, Address(SP, 1 * kWordSize));
+ // R5 = &a_digits[0]
__ add(R5, R5, Operand(TypedData::data_offset() - kHeapObjectTag));
// R6 = r_digits
__ ldr(R6, Address(SP, 0 * kWordSize));
+ // R6 = &r_digits[0]
__ add(R6, R6, Operand(TypedData::data_offset() - kHeapObjectTag));
// R7 = &digits[a_used >> 1], a_used is Smi.
@@ -1193,7 +1199,7 @@
// uint32_t aj = *ajp
__ ldr(R1, Address(R5, 0));
- // uint96_t t = R2:R1:R0 = 2*x*xi + aj + c
+ // uint96_t t = R7:R6:R0 = 2*x*xi + aj + c
__ mov(R0, Operand(0));
__ umaal(R0, R1, R2, R3); // R1:R0 = R3*R2 + R1 + R0 = x*xi + aj + 0.
__ umlal(R6, R7, R2, R3); // R7:R6 += R3*R2; c += x*xi.
@@ -1228,7 +1234,7 @@
void Intrinsifier::Bigint_estQuotientDigit(Assembler* assembler) {
- // TODO(regis): Implement.
+ // No unsigned 64-bit / 32-bit divide instruction.
}
« no previous file with comments | « runtime/vm/disassembler_arm64.cc ('k') | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698