[Android] Support unfocusable container views.

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
@@ skipping 563 matching lines @@
 }
 
 bool ContentViewCoreImpl::HasFocus() {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null())
     return false;
   return Java_ContentViewCore_hasFocus(env, obj.obj());
 }
 
+bool ContentViewCoreImpl::IsFocusable() {
+  JNIEnv* env = AttachCurrentThread();
+  ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
+  if (obj.is_null())
+    return false;
+  return Java_ContentViewCore_isFocusable(env, obj.obj());
+}
+
 void ContentViewCoreImpl::OnSelectionChanged(const std::string& text) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null())
     return;
   ScopedJavaLocalRef<jstring> jtext = ConvertUTF8ToJavaString(env, text);
   Java_ContentViewCore_onSelectionChanged(env, obj.obj(), jtext.obj());
 }
 
 void ContentViewCoreImpl::OnSelectionEvent(SelectionEventType event,
@@ skipping 238 matching lines @@
 }
 
 void ContentViewCoreImpl::SetFocus(JNIEnv* env, jobject obj, jboolean focused) {
   SetFocusInternal(focused);
 }
 
 void ContentViewCoreImpl::SetFocusInternal(bool focused) {
   if (!GetRenderWidgetHostViewAndroid())
     return;
 
+  if (!IsFocusable()) {
+    LOG(WARN) << "Unfocusable container view, treating as always focused.";

[jdduke (slow), 2014/11/05 21:20:31]

Hmm, we know that this condition exists, will the warning be anything more than
logspam at this point? I'd almost prefer a short comment explaining when this
condition might exist, and if we have follow-up plans then a link to the crbug.

Also, I wonder if it would make sense to instead embed this logic in
ContentViewCore.hasFocus()? Then other |HasFocus()| queries via RWHVAndroid
should just work.

+    focused = true;
+  }
+
   if (focused)
     GetRenderWidgetHostViewAndroid()->Focus();
   else
     GetRenderWidgetHostViewAndroid()->Blur();
 }
 
 void ContentViewCoreImpl::SendOrientationChangeEvent(JNIEnv* env,
                                                      jobject obj,
                                                      jint orientation) {
   if (device_orientation_ != orientation) {
@@ skipping 473 matching lines @@
       reinterpret_cast<ui::WindowAndroid*>(window_android),
       retained_objects_set);
   return reinterpret_cast<intptr_t>(view);
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content