Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 7012007: Chrome side of having the WebKit FileSystem API use WebPermissionClient for checking if using fil... (Closed)

Created:
9 years, 7 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
ericu, kinuko, michaeln
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Chrome side of having the WebKit FileSystem API use WebPermissionClient for checking if using file system is fine. Depends on https://bugs.webkit.org/show_bug.cgi?id=60683 BUG=76793 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85153

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -48 lines) Patch
M chrome/browser/chrome_worker_message_filter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chrome_worker_message_filter.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/content_settings_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/content_browser_client.h View 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.h View 3 chunks +2 lines, -8 lines 0 comments Download
M content/browser/file_system/file_system_dispatcher_host.cc View 3 chunks +1 line, -22 lines 0 comments Download
M content/browser/renderer_host/browser_render_process_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/worker_host/worker_process_host.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 4 chunks +20 lines, -5 lines 0 comments Download
M content/common/worker_messages.h View 2 chunks +7 lines, -1 line 0 comments Download
M content/worker/webworkerclient_proxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/worker/webworkerclient_proxy.cc View 1 2 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
I only need one of you to review, so whoever gets to it first.
9 years, 7 months ago (2011-05-12 02:18:36 UTC) #1
michaeln
Thnx for taking care this! http://codereview.chromium.org/7012007/diff/1/content/browser/file_system/file_system_dispatcher_host.h File content/browser/file_system/file_system_dispatcher_host.h (left): http://codereview.chromium.org/7012007/diff/1/content/browser/file_system/file_system_dispatcher_host.h#oldcode43 content/browser/file_system/file_system_dispatcher_host.h:43: HostContentSettingsMap* host_content_settings_map); nice! http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclient_proxy.cc ...
9 years, 7 months ago (2011-05-12 02:57:18 UTC) #2
ericu
I'm not quite following this. I see WorkerProcessHost::onAllowFileSystem that always returns true, but ChromeWorkerMessageFilter::onAllowFileSystem and ...
9 years, 7 months ago (2011-05-12 16:38:23 UTC) #3
jam
http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclient_proxy.cc File content/worker/webworkerclient_proxy.cc (right): http://codereview.chromium.org/7012007/diff/5004/content/worker/webworkerclient_proxy.cc#newcode160 content/worker/webworkerclient_proxy.cc:160: WebSecurityOrigin origin = frame->securityOrigin(); On 2011/05/12 02:57:19, michaeln wrote: ...
9 years, 7 months ago (2011-05-12 16:40:34 UTC) #4
jam
On 2011/05/12 16:38:23, ericu wrote: > I'm not quite following this. > > I see ...
9 years, 7 months ago (2011-05-12 16:42:01 UTC) #5
michaeln
9 years, 7 months ago (2011-05-12 18:09:17 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698