Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 701133002: Add unit test for SkDashPathEffect::asPoints' culling (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
danakj, egdaniel, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add unit test for SkDashPathEffect::asPoints' culling This is a follow on to (Crop the fast path dashed lines to the cull rect - https://codereview.chromium.org/699623003/) Committed: https://skia.googlesource.com/skia/+/2b9ee63c2423167cf39d7a5027db944057c74cfd

Patch Set 1 #

Patch Set 2 : Address code review comments #

Patch Set 3 : Add cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
M tests/DashPathEffectTest.cpp View 1 2 2 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
robertphillips
6 years, 1 month ago (2014-11-05 14:19:03 UTC) #3
robertphillips
PTAL. This version adds: 4 new test cases that straddle just the LTRB edges alternation ...
6 years, 1 month ago (2014-11-05 15:38:25 UTC) #4
egdaniel
lgtm
6 years, 1 month ago (2014-11-05 15:50:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701133002/20001
6 years, 1 month ago (2014-11-05 15:52:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/443) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/457)
6 years, 1 month ago (2014-11-05 15:54:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701133002/40001
6 years, 1 month ago (2014-11-05 15:57:56 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 16:06:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 2b9ee63c2423167cf39d7a5027db944057c74cfd

Powered by Google App Engine
This is Rietveld 408576698