Issue 701123003: Remove cached OptDrawState from GrDrawState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 701123003: Remove cached OptDrawState from GrDrawState. (Closed)

Created:
6 years, 1 month ago by egdaniel

Modified:
6 years, 1 month ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Remove cached OptDrawState from GrDrawState. Since we now snap and create the ODS one time in the inorder draw buffer, there is no need for us to keep a cached version of it around. BUG=skia: Committed: https://skia.googlesource.com/skia/+/69bb90c214ca554f0c41a9a9c88172dbdb1da563

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -81 lines)			Patch
M	src/gpu/GrDrawState.h	View		16 chunks	+3 lines, -21 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View		13 chunks	+1 line, -24 lines	0 comments	Download
M	src/gpu/GrOptDrawState.h	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/gpu/GrOptDrawState.cpp	View		1 chunk	+16 lines, -32 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701123003/20001

6 years, 1 month ago (2014-11-11 15:25:29 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-11 15:32:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/69bb90c214ca554f0c41a9a9c88172dbdb1da563