Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 701103002: Remove pure-virtual MediaStreamProvider::Unregister method and make overrides non-virtual. (Closed)

Created:
6 years, 1 month ago by Bernhard Bauer
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove pure-virtual MediaStreamProvider::Unregister method and make overrides non-virtual. The method is never called via virtual method dispatch, only directly on subclasses. Committed: https://crrev.com/0f0d0b39f878fdf6798235b2a4f7e01140d53083 Cr-Commit-Position: refs/heads/master@{#305222}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M content/browser/renderer_host/media/audio_input_device_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Bernhard Bauer
Please review.
6 years, 1 month ago (2014-11-07 12:13:33 UTC) #2
Bernhard Bauer
Tommi, can you take a look?
6 years, 1 month ago (2014-11-21 13:58:06 UTC) #5
tommi (sloooow) - chröme
lgtm
6 years, 1 month ago (2014-11-21 15:28:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701103002/1
6 years, 1 month ago (2014-11-21 15:28:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 16:19:57 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 16:20:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f0d0b39f878fdf6798235b2a4f7e01140d53083
Cr-Commit-Position: refs/heads/master@{#305222}

Powered by Google App Engine
This is Rietveld 408576698