Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 7011024: Two minor fixes to utman.sh (Closed)

Created:
9 years, 7 months ago by pdox
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Two minor fixes to utman.sh 1) Missing shell.split 2) Have --dry-run emit log info about what would be run Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5277

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/llvm/driver.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pdox
9 years, 7 months ago (2011-05-12 22:09:58 UTC) #1
robertm
LGTM
9 years, 7 months ago (2011-05-12 22:13:38 UTC) #2
(google.com) Derek Schuff
9 years, 7 months ago (2011-05-12 22:13:41 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698