Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 701043002: Get more of the mac GN build working. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
haraken, brettw
CC:
blink-reviews, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add comments #

Total comments: 4

Patch Set 3 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -82 lines) Patch
M Source/core/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/BUILD.gn View 1 2 2 chunks +62 lines, -56 lines 0 comments Download
M Source/web/BUILD.gn View 1 2 1 chunk +29 lines, -26 lines 0 comments Download
M public/BUILD.gn View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dirk Pranke
https://codereview.chromium.org/701043002/diff/20001/Source/core/BUILD.gn File Source/core/BUILD.gn (right): https://codereview.chromium.org/701043002/diff/20001/Source/core/BUILD.gn#newcode264 Source/core/BUILD.gn:264: "rendering/RenderThemeChromiumDefault.h", Brett: These files, despite the name, are actual ...
6 years, 1 month ago (2014-11-12 02:57:24 UTC) #2
brettw
LGTM, although I'm not a blink reviewer. https://codereview.chromium.org/701043002/diff/20001/Source/platform/BUILD.gn File Source/platform/BUILD.gn (right): https://codereview.chromium.org/701043002/diff/20001/Source/platform/BUILD.gn#newcode15 Source/platform/BUILD.gn:15: # TODO(GYP): ...
6 years, 1 month ago (2014-11-12 05:25:37 UTC) #3
Dirk Pranke
https://codereview.chromium.org/701043002/diff/20001/Source/platform/BUILD.gn File Source/platform/BUILD.gn (right): https://codereview.chromium.org/701043002/diff/20001/Source/platform/BUILD.gn#newcode15 Source/platform/BUILD.gn:15: # TODO(GYP): can't link Blink binaries yet. On 2014/11/12 ...
6 years, 1 month ago (2014-11-12 16:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701043002/40001
6 years, 1 month ago (2014-11-12 16:06:45 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 17:12:23 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 185222

Powered by Google App Engine
This is Rietveld 408576698