content: Move type selection logic out of GpuMemoryBufferImpl.

content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h"
 
 #include "base/bind.h"
 #include "content/common/gpu/client/gpu_memory_buffer_factory_host.h"
 #include "ui/gl/gl_bindings.h"
 
@@ skipping 113 matching lines @@
     case BGRA_8888:
       return false;
   }
 
   NOTREACHED();
   return false;
 }
 
 // static
 bool GpuMemoryBufferImplOzoneNativeBuffer::IsUsageSupported(Usage usage) {
   switch (usage) {

[alexst (slow to review), 2014/11/11 21:05:49]

I've been looking at the unittests, since there are many platforms with varying
capabilities, we should change this to
SurfaceFactoryOzone::GetInstance()->CanCreateNativePixmap(BufferUsage usage)
instead of the hardcoded values here. We just recently added it for situations
like this.

[reveman, 2014/11/12 05:09:20]

I made it use CanCreateNativePixmap in the SCANOUT case. MAP case is still hard
coded to false as we need to change the ::Create/:AllocateForChildProcess
functions to adjust that and I'd rather do that in a follow up.

     case MAP:
       return false;
     case SCANOUT:
       return true;
   }
 
   NOTREACHED();
   return false;
 }
 
-// static
-bool GpuMemoryBufferImplOzoneNativeBuffer::IsConfigurationSupported(
-    Format format,
-    Usage usage) {
-  return IsFormatSupported(format) && IsUsageSupported(usage);
-}
-
 void* GpuMemoryBufferImplOzoneNativeBuffer::Map() {
   NOTREACHED();
   return NULL;
 }
 
 void GpuMemoryBufferImplOzoneNativeBuffer::Unmap() {
   NOTREACHED();
 }
 
 uint32 GpuMemoryBufferImplOzoneNativeBuffer::GetStride() const {
   NOTREACHED();
   return 0;
 }
 
 gfx::GpuMemoryBufferHandle GpuMemoryBufferImplOzoneNativeBuffer::GetHandle()
     const {
   gfx::GpuMemoryBufferHandle handle;
   handle.type = gfx::OZONE_NATIVE_BUFFER;
   handle.id = id_;
   return handle;
 }
 
 }  // namespace content