Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 70103024: Remove unused V8ThrowException::createDOMException() helper. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
Reviewers:
haraken, Mike West, Inactive
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused V8ThrowException::createDOMException() helper. Followup minor issue from crrev.com/68563003 and remove an unused helper that also supplies an empty creation context. R=ch.dumez BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/bindings/v8/V8ThrowException.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
At your leisure, please take a look.
7 years, 1 month ago (2013-11-15 19:01:40 UTC) #1
Inactive
Assuming it builds, lgtm.
7 years, 1 month ago (2013-11-15 19:14:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/70103024/1
7 years, 1 month ago (2013-11-15 19:50:48 UTC) #3
haraken
LGTM
7 years, 1 month ago (2013-11-15 22:21:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/70103024/1
7 years, 1 month ago (2013-11-16 00:17:45 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-16 01:43:21 UTC) #6
Message was sent while issue was closed.
Change committed as 162148

Powered by Google App Engine
This is Rietveld 408576698