Update stale comments that still refer to URLRequestInetJob.

Update stale comments that still refer to URLRequestInetJob.

R=darin@chromium.org,willchan@chromium.org
BUG=271572
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235665

[willchan no longer on Chromium, 2013-11-15 16:26:29]

Lgtm
On Nov 15, 2013 11:36 AM, <wtc@chromium.org> wrote:

> Reviewers: darin, willchan,
>
> Description:
> Update stale comments that still refer to URLRequestInetJob.
>
> R=darin@chromium.org,willchan@chromium.org
> BUG=271572
> TEST=none
>
> Please review this at https://codereview.chromium.org/70103018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files (+7, -9 lines):
>   M     net/url_request/url_request_filter.h
>   M     net/url_request/url_request_filter.cc
>
>
> Index: net/url_request/url_request_filter.cc
> ===================================================================
> --- net/url_request/url_request_filter.cc       (revision 235275)
> +++ net/url_request/url_request_filter.cc       (working copy)
> @@ -95,9 +95,8 @@
>    delete iter->second;
>    hostname_handler_map_.erase(iter);
>    // Note that we don't unregister from the URLRequest ProtocolFactory as
> -  // this would left no protocol factory for the scheme.
> -  // URLRequestFilter::Factory will keep forwarding the requests to the
> -  // URLRequestInetJob.
> +  // this would leave no protocol factory for the remaining hostname and
> URL
> +  // handlers.
>  }
>
>  bool URLRequestFilter::AddUrlHandler(
> @@ -135,9 +134,8 @@
>    delete iter->second;
>    url_handler_map_.erase(iter);
>    // Note that we don't unregister from the URLRequest ProtocolFactory as
> -  // this would left no protocol factory for the scheme.
> -  // URLRequestFilter::Factory will keep forwarding the requests to the
> -  // URLRequestInetJob.
> +  // this would leave no protocol factory for the remaining hostname and
> URL
> +  // handlers.
>  }
>
>  void URLRequestFilter::ClearHandlers() {
> Index: net/url_request/url_request_filter.h
> ===================================================================
> --- net/url_request/url_request_filter.h        (revision 235275)
> +++ net/url_request/url_request_filter.h        (working copy)
> @@ -12,9 +12,9 @@
>  //     GURL("http://foo.com/"),
>  //     &URLRequestCustomJob::Factory);
>  //
> -// If URLRequestFilter::Factory can't find a handle for the request, it
> passes
> -// it through to URLRequestInetJob::Factory and lets the default network
> stack
> -// handle it.
> +// If URLRequestFilter::Factory can't find a handler for the request, it
> +// returns null to URLRequestJobManager and lets a built-in protocol
> factory
> +// handle the request.
>
>  #ifndef NET_URL_REQUEST_URL_REQUEST_FILTER_H_
>  #define NET_URL_REQUEST_URL_REQUEST_FILTER_H_
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-15 18:40:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/70103018/40001

[commit-bot: I haz the power, 2013-11-15 22:19:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/70103018/40001

[commit-bot: I haz the power, 2013-11-16 00:53:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/70103018/40001

[commit-bot: I haz the power, 2013-11-18 08:31:45]

Change committed as 235665