Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/lexer_generator/dfa.py

Issue 70103016: Experimental parser: small cleanup (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/lexer_generator/automaton.py ('k') | tools/lexer_generator/rule_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/lexer_generator/dfa.py
diff --git a/tools/lexer_generator/dfa.py b/tools/lexer_generator/dfa.py
index c3807e0eabe8c20b427da3e88b3038d957e5e771..049845a7e7e947fe1b90389c80ef057a493ef386 100644
--- a/tools/lexer_generator/dfa.py
+++ b/tools/lexer_generator/dfa.py
@@ -218,10 +218,9 @@ class DfaMinimizer:
action = state.action()
all_keys.append(state.key_iter())
if action:
- # TODO add this back
- # assert state in self.__terminal_set
if state not in terminal_set:
- action = "nonterminal action " + str(action)
+ assert action.entry_action()
+ action = ("nonterminal action", action)
elif state in terminal_set:
action = "terminal_set"
if not action in action_map:
« no previous file with comments | « tools/lexer_generator/automaton.py ('k') | tools/lexer_generator/rule_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698