Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 70103011: Remove TreatNullAs=NullString for HTMLFieldSetElement (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLFieldSetElement http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#htmlfieldsetelement The test passes only in Firefox Nightly, since neither IE11 Release Preview nor Opera 12.16 supports the property at all, verified by document.createElement('fieldset').name == undefined. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162023

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M LayoutTests/fast/dom/domstring-attribute-reflection.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +7 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/fieldset/fieldset-name.html View 1 1 chunk +3 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/fieldset/fieldset-name-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-14 09:42:15 UTC) #1
jochen (gone - plz use gerrit)
trybots seem to disagree
7 years, 1 month ago (2013-11-14 11:50:06 UTC) #2
philipj_slow
On 2013/11/14 11:50:06, jochen wrote: > trybots seem to disagree Updated the failing tests. In ...
7 years, 1 month ago (2013-11-14 12:04:01 UTC) #3
jochen (gone - plz use gerrit)
On 2013/11/14 12:04:01, philipj wrote: > On 2013/11/14 11:50:06, jochen wrote: > > trybots seem ...
7 years, 1 month ago (2013-11-14 12:06:30 UTC) #4
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-14 12:06:55 UTC) #5
philipj_slow
On 2013/11/14 12:06:30, jochen wrote: > On 2013/11/14 12:04:01, philipj wrote: > > On 2013/11/14 ...
7 years, 1 month ago (2013-11-14 12:09:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/70103011/60001
7 years, 1 month ago (2013-11-14 13:11:23 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 14:03:18 UTC) #8
Message was sent while issue was closed.
Change committed as 162023

Powered by Google App Engine
This is Rietveld 408576698