Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 701013004: CSP: Adding a test for appended script elements. (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
Reviewers:
jww, marja
CC:
blink-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@revert
Project:
blink
Visibility:
Public.

Description

CSP: Adding a test for appended script elements. How did we not have a test for this? Crazy. BUG=429244 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
A LayoutTests/http/tests/security/contentSecurityPolicy/script-src-appended-script.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/security/contentSecurityPolicy/script-src-appended-script-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
Mind taking a look, Joel? This depends on the revert in https://codereview.chromium.org/704723003/.
6 years, 1 month ago (2014-11-05 12:15:12 UTC) #2
Mike West
Hello Marja! You're still not a BlinkOn! Stampety stamp? :)
6 years, 1 month ago (2014-11-06 10:27:27 UTC) #4
marja
lgtm
6 years, 1 month ago (2014-11-06 10:29:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701013004/1
6 years, 1 month ago (2014-11-06 11:36:57 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 11:38:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184908

Powered by Google App Engine
This is Rietveld 408576698