Issue 700993002: Revert of Implement getPermissionStatus in MockWebPushClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700993002: Revert of Implement getPermissionStatus in MockWebPushClient (Closed)

Created:
6 years, 1 month ago by tkent

Modified:
6 years, 1 month ago

Reviewers:
Miguel Garcia, dcheng, Michael van Ouwerkerk

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@push_has_permission

Project:
chromium

Visibility:
Public.

Revert of Implement getPermissionStatus in MockWebPushClient (patchset #3 id:40001 of https://codereview.chromium.org/677073002/) Reason for revert: Broke a layout test, push_messaging/push-messaging-api-surface.html. Original issue's description: > Implement getPermissionStatus in MockWebPushClient > > Required for hasPermission LayoutTests > > BUG=401424 > > Committed: https://crrev.com/84b57b28f4766c4e411e6cc7125fc3400626a9f9 > Cr-Commit-Position: refs/heads/master@{#302722} TBR=mvanouwerkerk@chromium.org,dcheng@chromium.org,miguelg@chromium.org NOTREECHECKS=true NOTRY=true BUG=401424 Committed: https://crrev.com/62bb47df51eac10a618b9ad5e4b15d2bae8ab6d6 Cr-Commit-Position: refs/heads/master@{#302738}

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	M	content/shell/renderer/test_runner/mock_web_push_client.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	content/shell/renderer/test_runner/mock_web_push_client.cc	View		2 chunks	+0 lines, -17 lines	0 comments	Download

Total messages: 5 (0 generated)

tkent

Created Revert of Implement getPermissionStatus in MockWebPushClient

6 years, 1 month ago (2014-11-05 01:46:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700993002/1

6 years, 1 month ago (2014-11-05 01:48:27 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-05 01:50:47 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/62bb47df51eac10a618b9ad5e4b15d2bae8ab6d6
Cr-Commit-Position: refs/heads/master@{#302738}