Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 700953003: Avoid dec = -dec overflow when appending most negative signed integers. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Avoid dec = -dec overflow when appending most negative signed integers. BUG=skia:3096 Committed: https://skia.googlesource.com/skia/+/225fb98e1e321fa80e3457fafcd5d1fa14d9f8c3

Patch Set 1 #

Patch Set 2 : negate manually #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/core/SkString.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein
6 years, 1 month ago (2014-11-05 17:04:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700953003/1
6 years, 1 month ago (2014-11-05 17:08:39 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-05 17:08:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/610)
6 years, 1 month ago (2014-11-05 17:15:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700953003/20001
6 years, 1 month ago (2014-11-05 17:21:56 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-05 17:21:57 UTC) #10
reed1
wacky lgtm
6 years, 1 month ago (2014-11-05 19:34:30 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 19:35:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 225fb98e1e321fa80e3457fafcd5d1fa14d9f8c3

Powered by Google App Engine
This is Rietveld 408576698